[New] add TypeScript types #3097
Open
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3097 +/- ##
==========================================
- Coverage 95.28% 94.58% -0.70%
==========================================
Files 83 83
Lines 3584 3584
Branches 1252 1252
==========================================
- Hits 3415 3390 -25
- Misses 169 194 +25 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Can we add a tsc run, at least? |
OlivierZal
reviewed
Nov 8, 2024
OlivierZal
reviewed
Nov 8, 2024
G-Rath
force-pushed
the
add-types
branch
2 times, most recently
from
1713c9d
to
58d17dc
Compare
Done - note that it requires using |
ljharb
reviewed
Nov 9, 2024
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now I've just typed these out manually based on what we're using internally - while it would be good to have some tests at some point, I'm hoping/recommending not blocking on that for now as I think the types are small enough to be easy to maintain manually for the time being.
Resolves #3090